Looking back and forward 24 hours in the Monta API #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes seem almost too simple. Should I put the 24 hours in variables like the new
MatchingXToleranceMinutes
?Tested on my own data from the last 90 days, with only one failed calculation (edge-case, see more below).
The failed calculation is a super edge-case where the charge failed (for unknown reasons) at 67% and I continued it later in the app where it failed again!! after 8 minutes and I continued again. This yields 2 charges from the Monta API.
Just to make it clear, I don't think TeslaMateAgile should try to handle edge-cases like this, I just added it out of interest.