Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced DB calls to only when image is first created, added Quality setting for ImageMagick #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

styledev
Copy link

...hitting the DB when the image already exists. Also added $quality attribute for ImageMagick version.

…ly hitting the DB when the image already exists. Also added $quality attribute for ImageMagick version.
@MatthewRuddy
Copy link
Owner

Looks good, but all of the code indentation and formatting seems a bit off. Is this intentional? Bit of a Git noob here so not sure if I can correct it before merging.

Awesome work none-the-less, thanks for the contribution :)

@styledev
Copy link
Author

Oh, yeah. I indented all of the code so it would fold properly. The biggest thing though is just moving the DB call inside of file_exists which you could do on your own. And then for imagemagick adding the $quality = false variable to the function call and adding in the appropriate code noted in the creation step in my new code.

Dewey Bushaw
Co-Founder of Parapxl Corp.
www.parapxl.com

w. 949-276-3831

On Monday, February 18, 2013 at 5:57 PM, MatthewRuddy wrote:

Looks good, but all of the code indentation and formatting seems a bit off. Is this intentional? Bit of a Git noob here so not sure if I can correct it before merging.


Reply to this email directly or view it on GitHub (#5 (comment)).

@aristath
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants