fix and improve auto-temperature.py script
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it should not suddenly jump to `TEMP_DAY` when current_time == DUSK_TIME. Also, I made some performance and portability improvments.
|
Nice, thanks! |
MaxVerevkin
pushed a commit
that referenced
this pull request
May 12, 2024
It looks like after refactoring the code in #23, I just returned the original problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it should not suddenly jump to
TEMP_DAYwhen current_time == DUSK_TIME.Also, I made some performance and portability improvments. Other performance improvments can be made, but it might reduce accuracy and lead to unexpected results.
Also, the WINDOW is now 15m rather than 30m, since 15m are enough for the eyes to not notice.
The bug was here:
wl-gammarelay-rs/scripts/auto-temperature.py
Line 25 in cf79067
It should be: