Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risk of overwriting issue information during concurrent editing #53

Closed
sk-ys opened this issue Feb 5, 2024 · 7 comments
Closed

Risk of overwriting issue information during concurrent editing #53

sk-ys opened this issue Feb 5, 2024 · 7 comments

Comments

@sk-ys
Copy link
Contributor

sk-ys commented Feb 5, 2024

Under the current specification, if someone else updates an issue while you are editing it, the issue information in the edit area may be forcibly overwritten. I think it might be necessary to take measures such as issuing a warning and displaying the updated areas before overwriting if you were in the middle of editing.
What do you think?

@MayamaTakeshi
Copy link
Owner

That was a bug. I have added a commit to force detection of the conflict (fields in the Edit box should not be updated).
However at the moment, the conflict warning doesn't show the conflicting fields.

@MayamaTakeshi
Copy link
Owner

I have added another commit that I believe solves this issue.

@sk-ys
Copy link
Contributor Author

sk-ys commented Feb 7, 2024

Thank you for your response.
I'm sorry. I'll chelk it this weekend.

@sk-ys
Copy link
Contributor Author

sk-ys commented Feb 10, 2024

I have checked your update.
I understand that halting updates to the editing form will allow it to function similarly to the original Redmine.
However, the conflict confirmation screen will no longer appear when others update issues in the following order:

  1. Update items that are subject to conflict confirmation (journals with the 'has-detailes' class).
  2. Update journal notes only (journals without the 'has-detailes' class).

Once a conflict occurs during the issue page is open, I think it is necessary to ensure that lock_version is not automatically updated thereafter. Other than that, everything seems fine.

Furthermore, I am considering that there would be no problem with updating the editing form as before your commit if the user has not edited the entire form or a specific item.

@sk-ys
Copy link
Contributor Author

sk-ys commented Feb 12, 2024

I have tried to address the issue of the conflict confirmation screen not showing up if there are no details on the last update.
sk-ys@9c4ce95

@sk-ys
Copy link
Contributor Author

sk-ys commented Feb 12, 2024

I have added support for updates per attribute in issue form. Please confirm.
sk-ys@48914cc

@MayamaTakeshi
Copy link
Owner

Thanks. PR created and merged as #55.
(also, created #56)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants