Enable check names component

[Harry-Ramsey]

Enable check names component for TF-PSA-Crypto. Closes #52.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

• changelog provided | not required because: testing enhancement.
• framework PR provided Mbed-TLS/mbedtls-framework: #117
• mbedtls PR provided Mbed-TLS/mbedtls: not required.
• tests provided | not required because:

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

• Multiple simple commits
  • please structure your PR into a series of small commits, each of which does one thing
• Avoid force-push
  • please do not force-push to update your PR - just add new commit(s)
• See our Guidelines for Contributors for more details about the review process.

[Harry-Ramsey]

The failures reported here are to do with the test successfully running but have been propogated to TF-PSA-Crypto.

[ronald-cron-arm]

The failures reported here are to do with the test successfully running but have been propogated to TF-PSA-Crypto.

I am not sure to understand. What is needed for the new component tf_psa_crypto_check_names to run successfully? We cannot merge this PR in that state.

[Harry-Ramsey]

The failures reported here are to do with the test successfully running but have been propogated to TF-PSA-Crypto.

I am not sure to understand. What is needed for the new component tf_psa_crypto_check_names to run successfully? We cannot merge this PR in that state.

Sorry, there was an extreme number of errors much higher than expected. I forgot to remove code from check_names.py which overwrote selected paths resulting in these errors.

[ronald-cron-arm]

Regarding

#if defined(MBEDTLS_SSL_PROTO_TLS1_2) && defined(MBEDTLS_USE_PSA_CRYPTO) && \   
    !(defined(PSA_WANT_ALG_SHA_1) || defined(PSA_WANT_ALG_SHA_256) || defined(PSA_WANT_ALG_SHA_512))
#error "MBEDTLS_SSL_PROTO_TLS1_2 defined, but not all prerequisites"            
#endif 

in ./drivers/builtin/src/check_crypto_config.h, this should rather be in mbedtls:include/mbedtls/check_config.h. No need for defined(MBEDTLS_USE_PSA_CRYPTO) as MBEDTLS_USE_PSA_CRYPTO is always on now. Thus just:

#if defined(MBEDTLS_SSL_PROTO_TLS1_2) && \   
    !(defined(PSA_WANT_ALG_SHA_1) || defined(PSA_WANT_ALG_SHA_256) || defined(PSA_WANT_ALG_SHA_512))
#error "MBEDTLS_SSL_PROTO_TLS1_2 defined, but not all prerequisites"            
#endif

[ronald-cron-arm]

Regarding MBEDTLS_ERR_SSL_CRYPTO_IN_PROGRESS in crypto_config.h and ecp.h I think we can just remove the references to MBEDTLS_ERR_SSL_CRYPTO_IN_PROGRESS. Looking in ssl.h at the documentation of the TLS functions that return MBEDTLS_ERR_SSL_CRYPTO_IN_PROGRESS I do not feel the need to change their documentation because of the removals of the comments in TF-PSA-Crypto.

[ronald-cron-arm]

Regarding psa_util_internal.h:

#if defined(MBEDTLS_USE_PSA_CRYPTO) || defined(MBEDTLS_SSL_PROTO_TLS1_3)
extern const mbedtls_error_pair_t psa_to_ssl_errors[7];
#endif

can be moved to library/ssl_misc.h. It is defined in library/ssl_tls.c.

[ronald-cron-arm]

In entropy_poll.c

#if defined(MBEDTLS_TIMING_C)
#include "mbedtls/timing.h"
#endif

can just be removed it seems.

[ronald-cron-arm]

In crypto_config.h the note:

 * \note If MBEDTLS_TIMING_C is set - to enable the semi-portable timing
 *       interface - timing.c will include time.h on suitable platforms
 *       regardless of the setting of MBEDTLS_HAVE_TIME, unless
 *       MBEDTLS_TIMING_ALT is used. See timing.c for more information.

can be just removed. We already have the same note in MBEDTLS_TIMING_C documentation in mbedtls_config.h.