Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move configs to TF-PSA-Crypto #9908

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Move configs to TF-PSA-Crypto #9908

merged 3 commits into from
Feb 4, 2025

Conversation

Harry-Ramsey
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey commented Jan 14, 2025 •
edited
Loading

Description

This commit moves crypto configs to TF-PSA-Crypto and updates the relevant READMEs. Related TF-PSA-Crypto PR: #164

Closes issue: #9879.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: for repo split.
  • development PR provided.
  • framework PR not required.
  • 3.6 PR not required because: for repo split.
  • 2.28 PR not required because: for repo split.
  • tests provided.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@Harry-Ramsey Harry-Ramsey self-assigned this Jan 14, 2025
@Harry-Ramsey Harry-Ramsey added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels Jan 14, 2025
@Harry-Ramsey Harry-Ramsey mentioned this pull request Jan 14, 2025
Closed
3 tasks
@Harry-Ramsey Harry-Ramsey force-pushed the move-configs-to-tf-psa-crypto branch 7 times, most recently from 820db7d to 4712c74 Compare January 23, 2025 10:14
@Harry-Ramsey Harry-Ramsey mentioned this pull request Jan 23, 2025
Merged
3 tasks
@ronald-cron-arm ronald-cron-arm self-requested a review January 23, 2025 14:07
ronald-cron-arm
ronald-cron-arm requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost good to me, thanks. Just a few minor comments.

configs/ext/README.md Outdated Show resolved Hide resolved
configs/ext/README.md Outdated Show resolved Hide resolved
configs/crypto-config-symmetric-only.h Show resolved Hide resolved
@valeriosetti valeriosetti self-requested a review January 29, 2025 09:26
@Harry-Ramsey Harry-Ramsey force-pushed the move-configs-to-tf-psa-crypto branch 2 times, most recently from 8f206c5 to 1e28aba Compare January 29, 2025 09:49
@valeriosetti
Copy link
Contributor

valeriosetti commented Jan 29, 2025 •
edited
Loading

I think that the conflict on configs/ext/crypto_config_profile_medium.h requires a fix (the one on tf-psa-crypto instead is fine for now, as usual)

@ronald-cron-arm ronald-cron-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jan 29, 2025
ronald-cron-arm
ronald-cron-arm previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you need to rebase though to resolve the conflict regarding configs/ext/crypto_config_profile_medium.h.

@Harry-Ramsey Harry-Ramsey force-pushed the move-configs-to-tf-psa-crypto branch from 1e28aba to b852b7a Compare January 30, 2025 16:38
@Harry-Ramsey Harry-Ramsey force-pushed the move-configs-to-tf-psa-crypto branch from b852b7a to fdace67 Compare January 31, 2025 10:58
valeriosetti
valeriosetti previously approved these changes Jan 31, 2025
View reviewed changes
ronald-cron-arm
ronald-cron-arm previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harry-Ramsey
Move crypto configs to TF-PSA-Crypto
6e5dfa8 
This commit moves config-symmetric-only.h,
crypto-config-ccm-aes-sha256.h and crypto_config_profile_medium.h to
TF-PSA-Crypto.

Signed-off-by: Harry Ramsey <[email protected]>
@Harry-Ramsey
Update configs README
c89fa17 
This commit updates configs/ext/README.md to reflect the necessary files
which were removed from Mbed TLS.

Signed-off-by: Harry Ramsey <[email protected]>
@Harry-Ramsey
Update config paths in scripts
94c386a 
This commit updates the moved config paths in multiple script files.

Signed-off-by: Harry Ramsey <[email protected]>
@Harry-Ramsey Harry-Ramsey force-pushed the move-configs-to-tf-psa-crypto branch from fdace67 to 94c386a Compare February 4, 2025 12:54
ronald-cron-arm
ronald-cron-arm approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Feb 4, 2025
Merged via the queue into Mbed-TLS:development with commit 7b4b176 Feb 4, 2025
5 of 6 checks passed
@ronald-cron-arm ronald-cron-arm mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@valeriosetti valeriosetti valeriosetti approved these changes

Assignees

@Harry-Ramsey Harry-Ramsey

Labels
enhancement needs-review Every commit must be reviewed by at least two team members, size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harry-Ramsey @valeriosetti @ronald-cron-arm