Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add the same configuration again #616

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

McMartin
Copy link
Owner

@McMartin McMartin commented Mar 24, 2020

I found this weird behavior when I was doing some experiments for #615.

@MartyLake: please review, thanks!

Copy link
Collaborator

@MartyLake MartyLake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jucer_export_target_configuration() can be called several times with the
same exporter and configuration name. Before this change, it would
result in several identical configurations (same name and same
settings).
@McMartin McMartin force-pushed the do-not-stack-configurations branch from 32db863 to 0d88869 Compare March 24, 2020 22:52
@McMartin McMartin merged commit f89e164 into master Mar 25, 2020
@McMartin McMartin deleted the do-not-stack-configurations branch March 25, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants