Generator fixes for Qt 6.7 (#224) #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition This was especially problematic if the line ended with the comment, since then the next line would be added, too, even though the current one didn't end with a '\'
This prevented QT6_DECL_NEW_OVERLOAD_TAIL from being expanded correctly
they don't have an implementation. Often the friend definitions are the only definition there is, and we translate these definitions (currently always operators) to wrapper members then.
(this fixes some parser errors)
that might use the "spaceship" operator for C++20 and onwards. The generator had trouble to parse these. Simply replace the definitions with something that works for the generator.
…alue) to differentiate new methods with a different return value from the old, deprecated ones.
(this fixes some parser errors)
(this fixes some parser errors)
(this fixes some parser errors)
Add an entry "aliases" to a type entry in the type database, these types will automatically be changed to the main type in the generated code. This fixes the problem that in Qt 6.7 QAudio enums are used under the QtAudio alias. These enum names are now automatically mapped to the QAudio name with the right alias entries in the type database. This doesn't make QAudio available as QtAudio in Python, though.
Comment on lines
+304
to
+305
| // also set the access policy to public, just in case | ||
| fun->setAccessPolicy(CodeModel::Public); |
There was a problem hiding this comment.
Just in what case? Is this really needed?
There was a problem hiding this comment.
I simply copied this part from Binder::visitFunctionDefinition, where the same thing was done.
usiems
force-pushed
the
generator_fixes_for_Qt67
branch
2 times, most recently
from
c2075c9 to
d0655ea
Compare
Print the place in the code where the (ambiguous) parser error was emitted (currently only for GCC and MSVC)
usiems
force-pushed
the
generator_fixes_for_Qt67
branch
from
d0655ea to
35c65df
Compare
(should fix compare methods generated twice for Qt 5.12/5.15)
mrbean-bremen
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bunch of problems, so looking at the commits separately is recommended.
Also not all commits solve real problems, I also tried to reduce parser errors somewhat.