Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing commits & misc. #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArshansGithub
Copy link

@ArshansGithub ArshansGithub commented Mar 31, 2024

Hey! Thanks for developing such a useful extension. I came across an issue at competition where when using this extension, changes were only being staged and not commited. Taking a look today, I noticed that the commit message wasn't being passed in properly

I also simplified some of the git command (using -a flag)

Before:
git add -A
git commit -m "Update at "3/31/2024, 11:39:22 AM""

After:
git commit -a -m "Deploy at \"3/31/2024, 11:39:22 AM\""

image

I also changed the message from update to deploy since the code is only 'updated' per each deploy rather than using the word 'update'. I feel like the word 'update' would make more sense if it was per save of file but since this automatically commits on deploy it makes more sense to use 'deploy'. Just my opinion though.

@ArshansGithub
Copy link
Author

Hello just bumping this PR since the entire extension is essentially broken and doesn't do what its supposed to do :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant