CTXAPI-2569: Improve extractAssets to minimize memory and CPU consumption #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alahawash
changed the title
alahawash
force-pushed
the
bugfix/extractAssets_fix
branch
from
4290bb9 to
7dda326
Compare
gastonrobledo
requested changes
Mar 25, 2024
| { privatesAccessor } = require('@medable/mdctl-core-utils/privates'), | ||
| crypto = require('crypto') | ||
|
|
||
| class ExportSection { | ||
|
|
||
| constructor(content, key = '') { | ||
| constructor(content, key = '', sectionsWithResources) { |
There was a problem hiding this comment.
add sectionsWithResources = [] as default value otherwise it could fail after in the extractAssets.
alahawash
force-pushed
the
bugfix/extractAssets_fix
branch
from
7dda326 to
2eef5fe
Compare
gastonrobledo
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR focuses on optimizing the
extractAssetsprocess, with changes including:sectionsWithResourcesinstead ofSectionsCreatedto save only sections that contain resources. We also search the content document for resources in the constructor in order to do it only once per section.sectionsWithResourceswill be passed from the export_stream.