Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add in game force display dialog #4985

Merged
merged 19 commits into from
Jan 15, 2024
Merged

add in game force display dialog #4985

merged 19 commits into from
Jan 15, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Dec 30, 2023 •
edited
Loading

  • add in game force display dialog, similar to the lobby force display
  • double clicking a unit views it in unit display and centers unit on game board
  • popup menu for view readout of unit
  • add an indicator if a unit is done or not
  • show when a unit is destroyed

image
image

image

@kuronekochomusuke kuronekochomusuke added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface In Development (Draft) An additional way to mark something as a draft. Make it stand out more. labels Dec 30, 2023
@kuronekochomusuke kuronekochomusuke marked this pull request as draft December 30, 2023 20:51
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review January 3, 2024 23:25
@kuronekochomusuke kuronekochomusuke removed the In Development (Draft) An additional way to mark something as a draft. Make it stand out more. label Jan 4, 2024
@HammerGS
Copy link
Member

HammerGS commented Jan 6, 2024

Been playing around with this, very cool feature and have found no issues with it. But testing has been limited a smaller scale.

@HammerGS
Copy link
Member

Wanted to confirm if this is still in development or ready to go?

@kuronekochomusuke
Copy link
Collaborator Author

this is ready to review

Sleet01
Sleet01 requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor typos, otherwise looks good.

megamek/src/megamek/client/ui/swing/GUIPreferences.java Outdated Show resolved Hide resolved
@HammerGS HammerGS merged commit 3608486 into MegaMek:master Jan 15, 2024
4 checks passed
HammerGS added a commit that referenced this pull request Jan 15, 2024
@HammerGS
+ PR #4985: Add in game force display dialog
05bd085
@kuronekochomusuke kuronekochomusuke deleted the forceDisplay branch February 18, 2024 18:19
NickAragua added a commit to NickAragua/megamek that referenced this pull request Feb 7, 2025
@NickAragua
fix: bounds check for unit editor dialog (MHQ MegaMek#4985)
1882da2
NickAragua added a commit that referenced this pull request Feb 7, 2025
@NickAragua
Merge pull request #6512 from NickAragua/fix_unit_edit_out_of_bounds
6ee2ed6 
fix: bounds check for unit editor dialog (MHQ #4985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 requested changes

Assignees
No one assigned
Labels
GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuronekochomusuke @HammerGS @Sleet01