Allow objects to listen for changes to the equipment list #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for a Lab feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6391 +/- ##
============================================
- Coverage 28.57% 28.57% -0.01%
+ Complexity 14090 14087 -3
============================================
Files 2785 2785
Lines 273288 273310 +22
Branches 48408 48409 +1
============================================
- Hits 78103 78099 -4
- Misses 191203 191230 +27
+ Partials 3982 3981 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for a Lab feature, see the corresponding PR there: MegaMek/megameklab#1691.
JavaFX dependency grants ObservableList, which provides a single interface for detecting changes to the equipment list rather than trying to track down every method that might affect it.