Princess - Chat Commands fix #6433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sleet01
requested changes
Jan 24, 2025
Scoppio
force-pushed
the
feat/acar-princess-new-gui
branch
from
41b292d to
589ceee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6433 +/- ##
=========================================
Coverage 28.42% 28.43%
- Complexity 14093 14095 +2
=========================================
Files 2797 2797
Lines 274761 274773 +12
Branches 48607 48613 +6
=========================================
+ Hits 78113 78119 +6
- Misses 192664 192665 +1
- Partials 3984 3989 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chat commands syntax and how they were used in the chat were wrong and did not align with how they actually work.
This not only fix that, as it also fix an error that I commited where I mistakenly believed that you could set the bot behavior using discrete values, this fix also allows that.