Issue 6303: RFE - Hazardous Liquid Pool #6476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6476 +/- ##
============================================
- Coverage 28.57% 28.57% -0.01%
- Complexity 14407 14421 +14
============================================
Files 2798 2800 +2
Lines 275146 275291 +145
Branches 48678 48703 +25
============================================
+ Hits 78636 78671 +35
- Misses 191838 191942 +104
- Partials 4672 4678 +6 ☔ View full report in Codecov by Sentry. |
HammerGS
added
(RFE) Enhancement
|
Just saw this was still draft. Sorry. |
No worries! At least one of those things (the formatting on the big If) wasn't going to change - I'd copied it from another (old) method so I think I'll clean it up, extract it into its own method, and use it in both places. I'll request a review from you when I'm done with it all :) |
…Hazardous Liquid & Princess Support
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Hey @rjhancock this is ready for review. |
I can take a look now, but if this is for next dev cycle maybe we should wait until after 0.50.03 is built tomorrow? |
This should wait for the next cycle, yeah, so no rush. Thank you! |
| || ((en.getMovementMode() == EntityMovementMode.WIGE) | ||
| && (en.getOriginalWalkMP() > 0) && !eruption)) | ||
| && !en.isImmobile()) { | ||
| if (!isUnitEffectedByHazardousGround(en, eruption)) { |
megamek/unittests/megamek/client/bot/princess/BasicPathRankerTest.java
Outdated
Show resolved
Hide resolved
Another step towards #6303's completion!
Hazardous Liquid Pools
For map makers: Place this in tiles with water. The level of the Hazardous Liquid Pool will control if it should kick up damaging spray in high winds (not implemented yet) and/or move with water flow (not implemented yet either). You probably shouldn't place this on its own - in order to easily implement the "act as water for movement" the Hazardous Liquid Pool relies on being placed in water.
TODO: