-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Infantry Mob
Unit Files
#6490
Conversation
- Added "Mob" unit files for Small, Medium, Large, and Huge variants. These are used by the upcoming Prisoner rework.
Thinking we might want to give them a more specific name, Prisoners vs Mob. Since Mob would reflect more civilian in nature |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6490 +/- ##
=========================================
Coverage 28.57% 28.58%
- Complexity 14407 14409 +2
=========================================
Files 2798 2798
Lines 275146 275149 +3
Branches 48678 48678
=========================================
+ Hits 78636 78640 +4
+ Misses 191838 191835 -3
- Partials 4672 4674 +2 ☔ View full report in Codecov by Sentry. |
Won't we need a new Infantry or Entity subclass, since (from what little I've researched) Mobs have special rules for minimum size, disbandment, and adjacency? If that's the case, we have a few options:
|
I'd love us to fully implement the new Mob rules from IKEO, but has a short term bridge I think just making the unit files is the simplest option. But open to ideas, as mobs opens up some interesting options for Riot Duty contracts, etc |
If someone were willing to fully implement mobs I would absolutely make use of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HammerGS needs to approve as this is data but looks fine to me.
These are used by the upcoming Prisoner rework.