Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Infantry Mob Unit Files #6490

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Added Infantry Mob Unit Files #6490

merged 1 commit into from
Feb 6, 2025

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Feb 3, 2025

  • Added "Mob" unit files for Small, Medium, Large, and Huge variants. Created by @HammerGS.

These are used by the upcoming Prisoner rework.

- Added "Mob" unit files for Small, Medium, Large, and Huge variants.

These are used by the upcoming Prisoner rework.
@IllianiCBT IllianiCBT added Data Hammertime. Unofficial Anything that is not an official BT rule labels Feb 3, 2025
@IllianiCBT IllianiCBT self-assigned this Feb 3, 2025
@HammerGS
Copy link
Member

HammerGS commented Feb 3, 2025

Thinking we might want to give them a more specific name, Prisoners vs Mob. Since Mob would reflect more civilian in nature

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.58%. Comparing base (bbea8ac) to head (89df23e).
Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6490   +/-   ##
=========================================
  Coverage     28.57%   28.58%           
- Complexity    14407    14409    +2     
=========================================
  Files          2798     2798           
  Lines        275146   275149    +3     
  Branches      48678    48678           
=========================================
+ Hits          78636    78640    +4     
+ Misses       191838   191835    -3     
- Partials       4672     4674    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01
Copy link
Collaborator

Sleet01 commented Feb 3, 2025

Won't we need a new Infantry or Entity subclass, since (from what little I've researched) Mobs have special rules for minimum size, disbandment, and adjacency?

If that's the case, we have a few options:

  1. Subclass "Mob" into Prisoner, Insurgent, Civilians, Partisans, etc. (most work),
  2. Give Mob a special field that contains what it's composed of in case they have different behaviours (middle ground),
  3. Just use the name to indicate what kind of Mob a Mob is, but still subclass it from Entity or Infantry to contain the Mob rules (least work).

@HammerGS
Copy link
Member

HammerGS commented Feb 3, 2025

Won't we need a new Infantry or Entity subclass, since (from what little I've researched) Mobs have special rules for minimum size, disbandment, and adjacency?

If that's the case, we have a few options:

  1. Subclass "Mob" into Prisoner, Insurgent, Civilians, Partisans, etc. (most work),
  2. Give Mob a special field that contains what it's composed of in case they have different behaviours (middle ground),
  3. Just use the name to indicate what kind of Mob a Mob is, but still subclass it from Entity or Infantry to contain the Mob rules (least work).

I'd love us to fully implement the new Mob rules from IKEO, but has a short term bridge I think just making the unit files is the simplest option. But open to ideas, as mobs opens up some interesting options for Riot Duty contracts, etc

@IllianiCBT
Copy link
Collaborator Author

If someone were willing to fully implement mobs I would absolutely make use of them.

Copy link
Collaborator

@rjhancock rjhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HammerGS needs to approve as this is data but looks fine to me.

@HammerGS HammerGS merged commit eb63f99 into MegaMek:master Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Hammertime. Unofficial Anything that is not an official BT rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants