MML #1721: legacy infantry blk files #6531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Angle brackets need backslash escaping to show up in GitHub, I believe. |
|
good point :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6531 +/- ##
============================================
+ Coverage 28.56% 29.04% +0.48%
- Complexity 14495 15144 +649
============================================
Files 2815 2835 +20
Lines 277388 279129 +1741
Branches 49002 49214 +212
============================================
+ Hits 79226 81084 +1858
+ Misses 193446 192667 -779
- Partials 4716 5378 +662 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MegaMek/megameklab#1721
This allows loading legacy infantry files that have a "secondn" entry but no "secondary" (a number of secondary weapons but no weapon type for it). It appears that as recently as 49.16 such files could be produced with MML. In any case, this file check/file correction doesnt hurt.