Restore font replacement for pdf printing #1713
Merged
+9
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
===========================================
+ Coverage 2.13% 2.14% +0.01%
- Complexity 209 211 +2
===========================================
Files 271 271
Lines 31409 31405 -4
Branches 5342 5343 +1
===========================================
+ Hits 670 674 +4
+ Misses 30582 30572 -10
- Partials 157 159 +2 ☔ View full report in Codecov by Sentry. |
|
Does this affect how record sheets look when printed or does this just get rid of the error messages? |
|
It changes the printed sheet. |
|
Ok, I see now. There are some fonts that wouldn't be replaced with your chosen font previously, but if you were using Eurostile anyway, it shouldn't matter. Since export isn't affected we're not worried about this affecting CGL sheets, so you should be safe to merge this one. |
pavelbraginskiy
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes font tag replacement for PDF printing. Still, this only works with printing. For PDF export it has no effect but the cause is elsewhere (Apache FOP, apparently, that cannot use OS-installed fonts)
fixes #1695