Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RS display of information for Insulators/Pulse Modules/Capacitors #1728

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

pavelbraginskiy
Copy link
Member

@pavelbraginskiy pavelbraginskiy commented Feb 15, 2025

Previously Laser Insulators and RISC Laser Pulse Modules would be listed as ordinary equipment in the RS inventory readout.
This adjusts them to be displayed together with the weapon they're associated with, similar to how Artemis and PPC Capacitors work.

Additionally, since these enhancements (plus the capacitor) affect the weapon's basic stats and they take up a second line on the sheet, we can use that second line to display the new stats for for the weapon with that enhancement.

Example sheet:
image

In the future it would be nice to also update the value shown in the heat profile, but that's a separate (and more complex) issue that I won't be addressing for now.

@pavelbraginskiy pavelbraginskiy added the Record Sheets Record Sheets and PDF/Printing issue label Feb 15, 2025
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.14%. Comparing base (936ddb9) to head (1a38544).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1728   +/-   ##
========================================
  Coverage      2.14%   2.14%           
  Complexity      211     211           
========================================
  Files           271     271           
  Lines         31391   31381   -10     
  Branches       5344    5344           
========================================
  Hits            674     674           
+ Misses        30558   30548   -10     
  Partials        159     159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez
Copy link
Member

SJuliez commented Feb 15, 2025

Code is all good. Looks like a good idea to me, but needs approval by Hammer.

@HammerGS HammerGS merged commit b0a2e11 into MegaMek:master Feb 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Record Sheets Record Sheets and PDF/Printing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants