Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Contract Multiplier Again #5937

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Jan 30, 2025

  • Reorganized the employer multiplier logic to match CamOps.
  • Fixed a bug where we were using the full Reputation Rating and not Reputation Modifier.
  • Refactored difficulty modifier by ensuring calculations only occur for positive difficulty values. This likely wouldn't have changed anything, but it's cleaner so better.

Fix #5934

Reorganized the employer multiplier logic to improve code clarity and removed redundant calculations. Fixed a bug in difficulty modifier adjustment by ensuring calculations only occur for positive difficulty values. This refactor enhances maintainability and correctness without changing core functionality.
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.28%. Comparing base (3cd1c2e) to head (4a75538).
Report is 23 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5937      +/-   ##
============================================
- Coverage     10.29%   10.28%   -0.01%     
+ Complexity     6127     6123       -4     
============================================
  Files          1038     1039       +1     
  Lines        139206   139326     +120     
  Branches      20620    20633      +13     
============================================
- Hits          14336    14335       -1     
- Misses       123462   123587     +125     
+ Partials       1408     1404       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 05fa348 into MegaMek:master Jan 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Contract pay is too high on nightly version
3 participants