Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Improvements to Cargo Container Checks; added Unit Tests #5954

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

IllianiCBT
Copy link
Collaborator

  • Updated the cargo capacity logic to better account for destroyed locations and excluded unusable equipment.
  • Introduced comprehensive unit tests to validate calculations across various scenarios, ensuring correctness and robustness.

    Updated the cargo capacity logic to account for destroyed locations and excluded unusable equipment. Introduced comprehensive unit tests to validate calculations across various scenarios, ensuring correctness and robustness.
@IllianiCBT IllianiCBT added Bug Tests Issues or Pull Requests related to the project tests labels Feb 1, 2025
@IllianiCBT IllianiCBT self-assigned this Feb 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.35%. Comparing base (e743e52) to head (5aa4de9).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5954      +/-   ##
============================================
+ Coverage     10.28%   10.35%   +0.06%     
- Complexity     6122     6163      +41     
============================================
  Files          1039     1039              
  Lines        139358   139359       +1     
  Branches      20638    20639       +1     
============================================
+ Hits          14334    14428      +94     
+ Misses       123615   123503     -112     
- Partials       1409     1428      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammerGS HammerGS merged commit cf2ebad into MegaMek:master Feb 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Tests Issues or Pull Requests related to the project tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants