Skip to content

Commit

Permalink
Fix ece check
Browse files Browse the repository at this point in the history
  • Loading branch information
bureddy committed Oct 17, 2024
1 parent a9640cb commit 2a632df
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/ib_plugin.c
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,7 @@ ncclResult_t ncclIbConnect(int dev, void* opaqueHandle, void** sendComm, ncclNet
}

struct ncclIbConnectionMetadata meta;
memset(&meta, 0, sizeof(meta));
meta.ndevs = comm->base.ndevs;

// Alternate QPs between devices
Expand Down Expand Up @@ -1003,6 +1004,7 @@ ncclResult_t ncclIbAccept(void* listenComm, void** recvComm, ncclNetDeviceHandl

// Metadata to send back to requestor (sender)
struct ncclIbConnectionMetadata meta;
memset(&meta, 0, sizeof(meta));
for (int i = 0; i < rComm->base.ndevs; i++) {
rCommDev = rComm->devs + i;
ibDevN = mergedDev->devs[i];
Expand Down Expand Up @@ -1050,6 +1052,8 @@ ncclResult_t ncclIbAccept(void* listenComm, void** recvComm, ncclNetDeviceHandl
// Store this in our own qpInfo for returning to the requestor
if (meta.qpInfo[q].ece_supported)
NCCLCHECKGOTO(wrap_ibv_query_ece(qp->qp, &meta.qpInfo[q].ece, &meta.qpInfo[q].ece_supported), ret, fail);
} else {
meta.qpInfo[q].ece_supported = 0;
}
bool override_tc = (q == 0) ? true : false;
NCCLCHECKGOTO(ncclIbRtrQp(qp->qp, &rCommDev->base.gidInfo, remMeta.qpInfo[q].qpn, remDevInfo, override_tc), ret, fail);
Expand Down

0 comments on commit 2a632df

Please sign in to comment.