Plugin version v7 #122
Merged
Plugin version v7 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed old v4 version
wenbilliams
reviewed
Sep 28, 2023
| #include "net_v6.h" | ||
| #include "net_v5.h" | ||
| #include "net_v4.h" | ||
|
|
||
| #define NCCL_PLUGIN_SYMBOL ncclNetPlugin_v6 |
wenbilliams
reviewed
Sep 28, 2023
| ncclResult_t pluginInit_v5(ncclDebugLogger_t logFunction); | ||
|
|
||
| ncclNet_v7_t ncclNetPlugin_v7 = { | ||
| "NCCL RDMA Plugin v7", |
There was a problem hiding this comment.
Do you think this name should be more descriptive? I see this is following the old pattern
There was a problem hiding this comment.
this is a temporary name. It is overwritten when the actual plugin (ib/ucx) is assigned in line no 88.
wenbilliams
reviewed
Sep 28, 2023
| @@ -123,8 +123,8 @@ int ncclSharpAllGather(void *context, void *buf, int len) { | |||
|
|
|||
| p2p_plugin = nccl_p2p_get_plugin_type(); | |||
| if (p2p_plugin != NCCL_P2P_UCX) { | |||
| NCCLCHECK(NCCL_PLUGIN_SYMBOL.regMr(cComm->recvComm, buf, cComm->nranks*len, NCCL_PTR_HOST, &rMhandle)); | |||
There was a problem hiding this comment.
Ah I see, you just want to be explicit. Makes sense.
wenbilliams
reviewed
Sep 28, 2023
| .name = "UCX", | ||
| .init = nccl_ucx_init, | ||
| .devices = nccl_ucx_devices, | ||
| .getProperties = nccl_ucx_get_properties_v4, | ||
| .getProperties = nccl_ucx_get_properties_v6, |
There was a problem hiding this comment.
Should this be v5 or are you reusing v6 for v5 when it hasn't changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed old v4 version