Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: several updates #149

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: several updates #149

merged 1 commit into from
Nov 27, 2024

Conversation

rollandf
Copy link
Member

@rollandf rollandf commented Nov 27, 2024

  • fix some identation for list
  • align style on bash - remove captions

@@ -133,15 +136,6 @@ Install the Network Operator from the NVIDIA NGC chart using custom values:

helm show values nvidia/network-operator --version |network-operator-version| > values.yaml

.. code-block:: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return this part which had been removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted, and added a description before it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

- remove duplicate install section
- fix some identation for list
- align style on bash - remove captions

Signed-off-by: Fred Rolland <[email protected]>
Copy link
Contributor

@heyvister1 heyvister1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rollandf rollandf merged commit eb3078b into Mellanox:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants