[kernel] Add support for 1k size bootopts #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghaerr
reviewed
Dec 7, 2024
| @@ -1013,7 +1016,7 @@ pc98_int1b: | |||
| mov $DEF_OPTSEG,%ax // ES:BX = DEF_OPTSEG:0 | |||
| mov %ax,%es | |||
| xor %bx,%bx | |||
| mov $0x0201,%ax // BIOS read disk, 1 sector | |||
| mov $0x0202,%ax // BIOS read disk, 1 sector | |||
There was a problem hiding this comment.
Not a big deal, but the comment here still reads 1 sector, when we're now reading 2.
I've purposely not retabbed this file (setup.S) so as to keep it easier in sync with TLVC via diff - it should be identical. Was your last diff showing other differences this PR didn't update, and/or are other TLVC changes required?
There was a problem hiding this comment.
Thanks, I missed that one. And yes, it's a good idea to keep these in complete sync. I just checked the diff - there is no difference except in the comments. Plus there is the hello_mess - which could be fixed using UTS_SYSNAME from config.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover from #106