feat: log when a repo is renamed #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
edgarrmondragon
approved these changes
Sep 15, 2023
Comment on lines
+138
to
+141
| self.logger.info( | ||
| f"Repository name changed: {repo_full_name} \t" | ||
| f"New name: {name_with_owner}" | ||
| ) |
There was a problem hiding this comment.
Nit: Use printf-style for logs
Suggested change
| self.logger.info( | |
| f"Repository name changed: {repo_full_name} \t" | |
| f"New name: {name_with_owner}" | |
| ) | |
| self.logger.info( | |
| "Repository name changed: %s \tNew name: %s", | |
| repo_full_name, | |
| name_with_owner, | |
| ) |
https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/
There was a problem hiding this comment.
I feel like f-strings are a bit more readable in this case no? If Meltano has a strong feeling for %s I'll open an issue to change other instances of logs as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case when a repo is renamed by logging the info.