Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: releases replication key #254

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: releases replication key #254

merged 1 commit into from
May 15, 2024

Conversation

TylerHillery
Copy link
Contributor

I have updated the replication_key for GitHub releases to created_at field vs the published_at field.

The pubished_at field can be null according to the REST API endpoints for releases

This was causing the below error

{"TypeError: '>' not supported between instances of 'NoneType' and 'str'"}

created_at field can't be null so this should fix that.

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks @TylerHillery!

@edgarrmondragon edgarrmondragon merged commit 311d60e into MeltanoLabs:main May 15, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants