Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add run_attempt to workflow_runs schema #283

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

santhosh-fit
Copy link
Contributor

Summary
This pull request adds the run_attempt property to the workflow_runs schema. This will give the ability to filter out re-runs(run_attempt>1) in the workflow runs metrics.

Changes
Updated repository_streams.py to include run_attempt in the schema definition of the workflow_runs stream.

Testing

  1. Confirmed that Github REST API endpoint for workflow runs response returns run_attempt field in the response.
  2. Tested the changes locally using Meltano to ensure the run_attempt field is correctly included in response and populated in the target.

Copy link

sonarcloud bot commented Aug 2, 2024

@edgarrmondragon
Copy link
Member

Thanks @santhosh-fit!

@edgarrmondragon edgarrmondragon merged commit 1543b4c into MeltanoLabs:main Aug 2, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants