Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable fetching retried jobs #107

Conversation

a-meynard
Copy link
Contributor

fixes #86

reimplement #87 to resolve conflicts

@a-meynard
Copy link
Contributor Author

a-meynard commented Nov 18, 2024

Hello @edgarrmondragon 👋

Here is a PR that resolve conflicts that previous one had. I merged on legacy-stable as this is the default branch. Tell me if I should merge on main or something else :)

There is also one job on the CI that does not work, probably due to a missing secret. Is there something I should configure on my end ?

Thank you very much !

@edgarrmondragon
Copy link
Member

There is also one job on the CI that does not work, probably due to a missing secret. Is there something I should configure on my end ?

That's safe to ignore, and shouldn't even run on PRs from forks anyway 😅

@edgarrmondragon
Copy link
Member

Thanks @a-meynard!

@edgarrmondragon edgarrmondragon merged commit cb5f5a2 into MeltanoLabs:legacy-stable Nov 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Optionally) include retried GitLab jobs
2 participants