feat: Verify data in tests (row count and first row) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visch
requested changes
Nov 1, 2023
|
|
||
| with engine.connect() as connection: |
There was a problem hiding this comment.
I like that you want to consolidate the Tests but I think this test had a pretty solid data test and you removed a lot of the checks that were there before. We could just leave this one alone, or you could expand your verify data function to be able to work with multiple rows of data.
There was a problem hiding this comment.
Expanded to work with multiple rows.
visch
reviewed
Nov 27, 2023
| ) | ||
| assert result.rowcount == number_of_rows | ||
| result_dict = remove_metadata_columns(result.first()._asdict()) | ||
| assert result_dict == check_data |
There was a problem hiding this comment.
I'm impressed with Python's dictionary comparisons!
visch
approved these changes
Nov 27, 2023
This was referenced Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a method to verify data in tests. Currently only checks the total number of rows in a table and the data in the first row. I believe this provides good test coverage while keeping things manageable.
Closes #16