Merge pull request #492 from jdblischak/getfromnamespace

Use getFromNamespace instead of ::: to fix S3 dispatch for as_gt()
Merck · Nov 15, 2024 · 3c094b0 · 3c094b0
2 parents cbc103e + 7b7bc57
commit 3c094b0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 20 deletions.
diff --git a/R/as_gt.R b/R/as_gt.R
@@ -421,5 +421,6 @@ gsd_parts <- function(
 
 #' @export
 as_gt.simtrial_gs_wlr <- function(x, ...) {
-  simtrial:::as_gt.simtrial_gs_wlr(x, ...)
+  f <- utils::getFromNamespace("as_gt.simtrial_gs_wlr", "simtrial")
+  f(x, ...)
 }
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,19 +0,0 @@
-# gsDesign2 1.1.3
-
-We are aware of the following NOTE, and we also maintain {simtrial}:
-
-```
-* checking dependencies in R code ... NOTE
-Missing object imported by a ':::' call: ‘simtrial:::as_gt.simtrial_gs_wlr’
-```
-
-
-# gsDesign2 1.0.7
-
-## Resubmission
-
-This is a resubmission. In this version I have:
-
-* Exported the internal functions to avoid the use of ::: in code examples.
-
-* Fixed the write path issue by moving the test fixture generation script to data-raw/ which is not included in the package.