Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as_gt()
examples are skipped duringR CMD check
since they generate a lot of extraneous output (#334, #338). However, this means they are not regularly tested. While working on #497, I discovered that the examples withgs_power_ahr()
andgs_power_wlr()
were broken.I did a
git bisect
to determine that the example broke in a6a0166 when we updatedgs_power_ahr()
andgs_power_wlr()
to require that users specifytotal_spend
(#396, #398).I fixed the examples as was done for
as_rtf()
in #398 and also updated the examples to be run duringR CMD check
to prevent this from happening again. The downsides are thatgsDesign2.Rcheck/gsDesign2-Ex.Rout
gets bloated with all theas_gt()
output, and the examples are also decently long-running. If CRAN complains about either of these on the next submission, then we can re-evaluate the strategy. An alternative would be to copy the examples into a test file, and then return to skipping the examples duringR CMD check
.