[DUX-2058] Fix bug in use of child_process #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbrice
changed the title
michaelkitson
approved these changes
Mar 18, 2024
| export function make<T>(spec: Spec, f: (stdout: string) => T): IAsyncProcess<T> { | ||
| export function spawn(spec: Spec): IAsyncProcess<void> { | ||
| return make<void>(spec, (cmd, opts, resolve) => { | ||
| const proc = child_process.spawn(cmd, [], {...opts, shell: true}) |
There was a problem hiding this comment.
Huh, I wouldn't have expected spawn(cmd, [], ...) to work, but I'm glad it does, that seems way easier than parsing it! I assume that is what shell: true is for?
|
A PR to release these changes has been created, bumping the version from 3.2.1 to 3.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
child_process.execto capturestdoutso that it can be processed as one big string. This works great for short-lived CLI utilities, but when used with a long-lived daemon (such as when used withactivateCommand) the stdout from the long-lived process overfills a buffer, causing the process to fail.This patch changed the
activateCommandto usechild_process.spawnwhile still preserving the use ofchild_process.execfor everything else.