Run after-restart hooks before eval commands and test suites #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
May 21, 2024
| self.run_hooks(event, log).await?; | ||
| } | ||
|
|
||
| let event = events[N - 1]; |
There was a problem hiding this comment.
Is there a way to enforce that N is greater than 0?
Alternatively, another way to guarantee the same thing is to split the events argument into two arguments: events: [LifecycleEvent] (for all but the last event) and event: LifecycleEvent (for the very last event). This is essentially a poor person's encoding of a non-empty list.
I don't feel strongly about this, though.
There was a problem hiding this comment.
Not possible yet apparently :(
9999years
deleted the
rebeccat/dux-2307-run-after-restart-hooks-before-eval-commands-and-test-suites
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency between after-startup and after-restart hooks