Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI (choose correct python executable) #483

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

currocam
Copy link
Contributor

This PR fixes #482

As you already said in the issue, something must have changed since the last time the tests ran. Other people have very similar issues:

conda-incubator/setup-miniconda#371
conda-incubator/setup-miniconda#355

I haven't figured out what exactly has changed, but I think the issue was that the correct Python executable (the one for which we installed the pytest library) was not in PATH. You cannot ssh to the GitHub action (as far as I know) so it's extremely annoying to debug. I ended up going through their documentation and updating the code according to their "best practices". Eventually, it all worked out.

@bhaller
Copy link
Contributor

bhaller commented Nov 11, 2024

Interesting. I think you shifted us to mamba a while back, in cbc9e33. I don't recall what the motivation was; I think maybe (1) the CI was failing on recent macOS targets because they had discontinued something else, and/or (b) we wanted to get off of anaconda because they are threatening to charge money in future. Maybe you can track down some discussion, associated with that commit? There must've been a PR for that change, but I'm not sure how to go from a commit to the PR that the commit was in, in GitHub's UI. :-O Anyhow, thank you very much for this patch, @currocam. If you believe it to be the correct fix, even in light of that previous commit, then I'll approve it since you know far better than I. I just wanted to check with you about this first, to make sure. :->

@currocam
Copy link
Contributor Author

currocam commented Nov 11, 2024

Hi Ben,
I think this #466 is the PR you are thinking of. In fact, using conda implies using the "default" channel, for which you are suppose to pay if you are a big organization. I don't think they are truly implementing it, but I prefer choosing the fully open-source "flavour".

However, my truly original motivation to switch to mamba was that (1) it was the solver recommended in the documentation of the GitHub action plugin and (2) I was able to solve the MacOS issue first with mamba (#457).

Perhaps the error was related to the latest automatic update in the version of the dependency the plugin we use to handle the cache? Otherwise, I don't see any reason why it would fail only in Windows.

I think this PR is OK to merge.

@bhaller bhaller merged commit 6c09166 into MesserLab:master Nov 11, 2024
18 checks passed
@bhaller bhaller mentioned this pull request Nov 11, 2024
@currocam currocam deleted the broken-windows-ci branch November 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no module named pytest" error in GitHub Actions for Windows
2 participants