Skip to content

Commit

Permalink
Merge pull request #755 from MetaCell/fix/CH-130-CH-131
Browse files Browse the repository at this point in the history
Hotfix release 2.3.1
  • Loading branch information
filippomc authored Jul 4, 2024
2 parents df30a63 + d111732 commit ac1f272
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 22 deletions.
1 change: 0 additions & 1 deletion applications/jupyterhub/zero-to-jupyterhub-k8s
Submodule zero-to-jupyterhub-k8s deleted from c92c12
14 changes: 1 addition & 13 deletions deployment/codefresh-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,13 @@ steps:
repo: '${{CF_REPO_OWNER}}/${{CF_REPO_NAME}}'
revision: '${{CF_BRANCH}}'
git: github
post_main_clone:
title: Post main clone
type: parallel
stage: prepare
steps:
- title: Cloning cloud-harness repository...
type: git-clone
stage: prepare
repo: https://github.com/MetaCell/cloud-harness.git
revision: '${{CLOUDHARNESS_BRANCH}}'
working_directory: .
git: github
prepare_deployment:
title: Prepare helm chart
image: python:3.9.10
stage: prepare
working_directory: .
commands:
- bash cloud-harness/install.sh
- bash install.sh
- harness-deployment . -n test-${{NAMESPACE_BASENAME}} -d ${{DOMAIN}} -r ${{REGISTRY}}
-rs ${{REGISTRY_SECRET}} -e test --write-env -N -i samples
- cat deployment/.env >> ${{CF_VOLUME_PATH}}/env_vars_to_export
Expand Down
4 changes: 2 additions & 2 deletions docs/applications/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Create a new applicaton

Any Dockerfile added in a subfolder below the [applications](./applications) directory is interpreted as an application part of the deployment.
Any Dockerfile added in a subfolder below the [applications](../../applications) directory is interpreted as an application part of the deployment.

## Use harness-application

Expand Down Expand Up @@ -116,6 +116,6 @@ The most important configuration entries are the following:
- `livenessProbe`: defines a a url to use as a liveness probe

# Example code
- [Sample application](../applications/samples) is a sample web application providing working examples of deployment configuration, backend and frontend code.
- [Sample application](../../applications/samples) is a sample web application providing working examples of deployment configuration, backend and frontend code.


3 changes: 2 additions & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ CURRENT_PATH=$(pwd)
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

cd $SCRIPT_DIR

pip install --upgrade pip
cat requirements.txt
pip install -r requirements.txt

cd $CURRENT_PATH
3 changes: 2 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
-e libraries/models
-e libraries/cloudharness-utils
-e tools/deployment-cli-tools

colorama<0.5.0,>=0.4.3
typer<0.12.0
9 changes: 5 additions & 4 deletions tools/deployment-cli-tools/ch_cli_tools/codefresh.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,11 @@ def add_unit_test_step(app_config: ApplicationHarnessConfig):
image=image_tag_with_variables(app_name, tag, base_image_name),
)

codefresh_steps_from_base_path(join(root_path, BASE_IMAGES_PATH), CD_BUILD_STEP_BASE,
fixed_context=relpath(root_path, os.getcwd()), include=helm_values[KEY_TASK_IMAGES].keys())
codefresh_steps_from_base_path(join(root_path, STATIC_IMAGES_PATH), CD_BUILD_STEP_STATIC,
include=helm_values[KEY_TASK_IMAGES].keys())
if helm_values[KEY_TASK_IMAGES]:
codefresh_steps_from_base_path(join(root_path, BASE_IMAGES_PATH), CD_BUILD_STEP_BASE,
fixed_context=relpath(root_path, os.getcwd()), include=helm_values[KEY_TASK_IMAGES].keys())
codefresh_steps_from_base_path(join(root_path, STATIC_IMAGES_PATH), CD_BUILD_STEP_STATIC,
include=helm_values[KEY_TASK_IMAGES].keys())

codefresh_steps_from_base_path(join(
root_path, APPS_PATH), CD_BUILD_STEP_PARALLEL)
Expand Down

0 comments on commit ac1f272

Please sign in to comment.