Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Move from alpine to debian image #719

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Conversation

ddelpiano
Copy link
Member

@ddelpiano ddelpiano commented Jan 25, 2024

Closes #CH-95

Implemented solution:

  • replaced the alpine with the debian base image in cloudharness-base image
  • replace the occurrences of cloudharness-base-debian with cloudharness-base and apk to apt where found
  • created a configuration script for the migration, if the keyword is found in a file then it iterates the old words and ask the user if they want to replace them with the new, a python script runs the migration as well.
  • integrated the above with harness_deployment and 2 new flags (one for migration, one for migration without input from the user)

How to test this PR:

  • manually create an application in the applications folder and make this use the CLOUDHARNESS_BASE_DEBIAN image to create the application container, and also apk to install some packages

  • run the harness_deployment tool with the migration flag

  • check the files wiht the keyword created at the first step

  • automated testing has been implemented as well to test the utils created and the perform_migration function.

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@ddelpiano ddelpiano marked this pull request as draft January 25, 2024 15:16
… the applications based on a keyword and a dictionary of words to replace if the occurrence is found
@ddelpiano ddelpiano changed the title Move from alpine to debian image Feature - Move from alpine to debian image Feb 10, 2024
@ddelpiano ddelpiano requested a review from filippomc February 10, 2024 01:48
@ddelpiano ddelpiano marked this pull request as ready for review February 10, 2024 01:49
@ddelpiano ddelpiano added enhancement New feature or request breaking change labels Feb 23, 2024
@ddelpiano ddelpiano requested a review from filippomc July 28, 2024 22:10
@ddelpiano
Copy link
Member Author

@filippomc the changes requested are done. Thx

@ddelpiano ddelpiano requested a review from filippomc October 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants