CH-100 Add preliminary docker-compose support #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit c698bbadf4f5cf41a59818d3738258fb29919249 Author: aranega <[email protected]> Date: Wed Feb 7 08:55:45 2024 -0600 CH-100 Add second path using pathlib commit 0422bfe9860f272354c1faadd851d37b4976650a Author: aranega <[email protected]> Date: Wed Feb 7 07:33:43 2024 -0600 CH-100 Add first port to pathlib
…ss into feature/CH-100
filippomc
reviewed
Sep 17, 2024
|
|
||
| return values | ||
|
|
||
| def inject_entry_points_commands(self, helm_values, image_path, app_path): |
There was a problem hiding this comment.
I'm not sure this is necessary: we do command overriding on skaffold to enable debugging that doesn't work well with unicorn
filippomc
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CH-100
Adds a preliminary docker-compose support for cloud-harness.
Implemented solution:
The implementation relies on helm templates dedicated for docker-compose.
A new folder can be defined and used for all docker-compose related templates, while a mechanism allows one to define where some files can be generated.
On a general note, all files that needs to be generated from templates and needs to be embedded in containers needs to be generated in a specific directory in the file system.
The generated files are then mounted in the countainer.
How to test this PR:
There is a new option
--docker-composethat can be passed as argument of the command line for theharness-deploymentcommand.This new option will generate in
deployment/composeall the templates and specific files for the cloudharness deployment, adeployment/docker-compose.yamlwill be produced, and theskaffold.yamlfile is modified to target docker-compose for deployment (even if this feature is still not yet supported).Sanity checks:
Breaking changes (select one):
breaking-changePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):