Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH-91 Add support for envmap #757

Merged
merged 8 commits into from
Jul 30, 2024
Merged

CH-91 Add support for envmap #757

merged 8 commits into from
Jul 30, 2024

Conversation

condar-metacell
Copy link
Contributor

@condar-metacell condar-metacell commented Jul 30, 2024

Closes CH-91

Implemented solution

Added support for envmap in harness applications which will add named environment variables to the pods, noted env as deprecated though not yet obsoleted.
...

How to test this PR

Build and deploy the samples api. Call the Samples /api/ping endpoint, if a 200 response is received then the environment variables were correctly set in the pod.
...

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@condar-metacell condar-metacell added enhancement New feature or request python Pull requests that update Python code new feature labels Jul 30, 2024
@condar-metacell condar-metacell changed the title Feature/ch 91 CH-91 Add support for envmap Jul 30, 2024
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, great first PR!

@filippomc filippomc merged commit f619252 into develop Jul 30, 2024
6 of 7 checks passed
@filippomc filippomc deleted the feature/CH-91 branch July 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants