Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo4J browser #768

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Neo4J browser #768

merged 7 commits into from
Sep 11, 2024

Conversation

filippomc
Copy link
Collaborator

@filippomc filippomc commented Sep 10, 2024

Closes CH-32

Implemented solution

A new application has been added based on the neo4j reverse proxy -- see https://neo4j.com/docs/operations-manual/current/kubernetes/accessing-neo4j-ingress/

How to test this PR

harness-deployment ... -i neo4j -d [DOMAIN] and go to neo4j.[DOMAIN]

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@filippomc filippomc requested a review from alxbrd September 10, 2024 11:09
Copy link
Contributor

@alxbrd alxbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc filippomc merged commit 958aa9f into develop Sep 11, 2024
6 of 7 checks passed
@filippomc filippomc deleted the feature/CH-32 branch September 11, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants