Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(accounts-controller): improve uuid mocks #5005

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Nov 29, 2024

Explanation

Unify the UUID mocking. With this new refactor we longer have to specify each returned values of mockUUID. It also handles the non-registered accounts (in this case, a random UUID will be generated).

References

N/A

Changelog

N/A (those changes only impact tests)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly marked this pull request as ready for review November 29, 2024 11:24
@ccharly ccharly requested a review from a team as a code owner November 29, 2024 11:24
@ccharly ccharly merged commit 875e8a1 into main Jan 16, 2025
117 checks passed
@ccharly ccharly deleted the refactor/accounts-controller-tests branch January 16, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants