Use dev Node to check for unsupported Node builtins in tests #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `n/no-unsupported-features/es-builtins`, `n/no-unsupported-features/es-syntax`, and `n/no-unsupported-features/node-builtins` ESLint rules ensure that production code is not using features of JavaScript that are unsupported by the expected version of Node. It does this by keeping track of which versions various features will become generally available and failing if the version of Node it sees does not match. By default, this rule uses `engines.node` to know which is the "expected version of Node". While that is fine for production code, we use a later version of Node — which is set to the current LTS version — for tests, and therefore we may be allowed to use features that were once experimental in previous versions. To fix this, this commit overrides the three `n/no-unsupported-features/*` rules to use the current LTS of Node for tests.
mcmire
commented
Jan 15, 2025
| @@ -83,6 +85,11 @@ const config = createConfig([ | |||
| 'jest/prefer-lowercase-title': 'warn', | |||
| 'jest/prefer-strict-equal': 'warn', | |||
| }, | |||
| settings: { | |||
There was a problem hiding this comment.
4 tasks
4 tasks
cryptodev-2s
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
n/no-unsupported-features/es-builtins,n/no-unsupported-features/es-syntax, andn/no-unsupported-features/node-builtinsESLint rules ensure that production code is not using features of JavaScript that are unsupported by the expected version of Node. It does this by keeping track of which versions various features will become generally available and failing if the version of Node it sees does not match.By default, this rule uses
engines.nodeto know which is the "expected version of Node". While that is fine for production code, we use a later version of Node — which is set to the current LTS version — for tests, and therefore we may be allowed to use features that were once experimental in previous versions.To fix this, this commit overrides the three
n/no-unsupported-features/*rules to use the current LTS of Node for tests.References
Changelog
(N/A)
Checklist