fix: prevent PhishingController
invalid API requests with -Infinity timestamp
#5385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes an edge case in the PhishingController where empty phishingLists would trigger API requests with an invalid
-Infinity
timestamp.When the phishingLists array is empty and
#updateHotlist()
is called, the code attempts to get the maximum timestamp usingMath.max(...this.state.phishingLists.map(({ lastUpdated }) => lastUpdated))
. With an empty array, this results in-Infinity
, causing invalid API requests to/v1/diffsSince/-Infinity
.Added an early return check in
#updateHotlist()
whenphishingLists
is empty to prevent making the invalid API request.References
Fixes #4194
Changelog
Check Changelog
Checklist