refactor(accounts-controller): use type-cast instead of @ts-expect-error
#5568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Commenting out the
@ts-expect-error
was not very reliable sometimes (it works everytime on the CI, but not everytime when compiling/running tests locally). We sometimes have to uncomment the directive to run the tests (which is a bit annoying and force you to have some "unstaged change" ingit
).The type-cast does get rid of the compile-error with
WritableDraft
while still providing the same "object signature" and has 0 impact at runtime either. So this is safe.References
N/A
Changelog
N/A
Checklist