Skip to content

perf(accounts-controller): add new setAccountNameAndSelectAccount action #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 25, 2025

Explanation

Combinining setAccountName + setSelectedAccount to avoid having 2 update blocks.

References

N/A

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly
Copy link
Contributor Author

ccharly commented Apr 25, 2025

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-f2d81961",
  "@metamask-previews/address-book-controller": "6.0.3-preview-f2d81961",
  "@metamask-previews/announcement-controller": "7.0.3-preview-f2d81961",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-f2d81961",
  "@metamask-previews/approval-controller": "7.1.3-preview-f2d81961",
  "@metamask-previews/assets-controllers": "58.0.0-preview-f2d81961",
  "@metamask-previews/base-controller": "8.0.0-preview-f2d81961",
  "@metamask-previews/bridge-controller": "17.0.0-preview-f2d81961",
  "@metamask-previews/bridge-status-controller": "14.0.0-preview-f2d81961",
  "@metamask-previews/build-utils": "3.0.3-preview-f2d81961",
  "@metamask-previews/chain-agnostic-permission": "0.4.0-preview-f2d81961",
  "@metamask-previews/composable-controller": "11.0.0-preview-f2d81961",
  "@metamask-previews/controller-utils": "11.7.0-preview-f2d81961",
  "@metamask-previews/delegation-controller": "0.1.0-preview-f2d81961",
  "@metamask-previews/earn-controller": "0.12.0-preview-f2d81961",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-f2d81961",
  "@metamask-previews/ens-controller": "16.0.0-preview-f2d81961",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-f2d81961",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-f2d81961",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-f2d81961",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-f2d81961",
  "@metamask-previews/keyring-controller": "21.0.3-preview-f2d81961",
  "@metamask-previews/logging-controller": "6.0.4-preview-f2d81961",
  "@metamask-previews/message-manager": "12.0.1-preview-f2d81961",
  "@metamask-previews/multichain": "4.0.0-preview-f2d81961",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-f2d81961",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-f2d81961",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-f2d81961",
  "@metamask-previews/name-controller": "8.0.3-preview-f2d81961",
  "@metamask-previews/network-controller": "23.2.0-preview-f2d81961",
  "@metamask-previews/notification-services-controller": "6.0.0-preview-f2d81961",
  "@metamask-previews/permission-controller": "11.0.6-preview-f2d81961",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-f2d81961",
  "@metamask-previews/phishing-controller": "12.5.0-preview-f2d81961",
  "@metamask-previews/polling-controller": "13.0.0-preview-f2d81961",
  "@metamask-previews/preferences-controller": "17.0.0-preview-f2d81961",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-f2d81961",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-f2d81961",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-f2d81961",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-f2d81961",
  "@metamask-previews/sample-controllers": "0.1.0-preview-f2d81961",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-f2d81961",
  "@metamask-previews/signature-controller": "27.1.0-preview-f2d81961",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-f2d81961",
  "@metamask-previews/transaction-controller": "54.2.0-preview-f2d81961",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-f2d81961"
}

@ccharly ccharly changed the title feat(accounts-controller): add new setAccountNameAndSelectAccount action perf(accounts-controller): add new setAccountNameAndSelectAccount action Apr 28, 2025
@ccharly ccharly force-pushed the perf/combined-accounts-controller-actions branch from aabb780 to ded28ee Compare April 28, 2025 21:55
@ccharly ccharly force-pushed the perf/combined-accounts-controller-actions branch from ded28ee to 3428d20 Compare April 29, 2025 08:09
@ccharly ccharly marked this pull request as ready for review April 29, 2025 14:46
@ccharly ccharly requested review from a team as code owners April 29, 2025 14:46
@ccharly ccharly enabled auto-merge (squash) April 29, 2025 15:37
@ccharly ccharly merged commit 7dfd62e into main Apr 29, 2025
202 checks passed
@ccharly ccharly deleted the perf/combined-accounts-controller-actions branch April 29, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation
3 participants