feat: Updating blue to brand evolution blurple #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
changed the title
| @@ -19,7 +19,7 @@ | |||
| "description": "For raised neutral surface above background/default." | |||
| }, | |||
| "default-hover": { | |||
| "value": "#1A1B1C", | |||
| "value": "#1a1b1c", | |||
There was a problem hiding this comment.
Same color. Just changing to lowercase. We are pretty inconsistent with this across the board so we can resolve in a enablement sprint
| @@ -77,7 +77,7 @@ export type ThemeColors = { | |||
| inverse: string; | |||
| }; | |||
| primary: { | |||
| /** For primary semantic elements: interactive, active, selected... */ | |||
| /** For primary semantic elements: interactive, active, selected */ | |||
There was a problem hiding this comment.
Removing three dots
brianacnguyen
previously approved these changes
Mar 12, 2025
Co-authored-by: Brian August Nguyen <brianacnguyen@gmail.com>
7 tasks
Adjusted values for - primary.default-hover to #384DF5 - primary.default-pressed #2B3EDA
Adjusted primary-default-hover to "9EAAFF"
|
@georgewrmarshall LIGHT
DARK
|
brianacnguyen
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the design tokens to align with the brand evolution "blurple" colors and fixes some casing inconsistencies introduced in #428. The changes primarily affect the blue color palette across our design system, ensuring consistency between Figma values and our implementation.
Key updates include:
Related issues
Fixes: #475
Manual testing steps
yarn storybookyarn workspace @metamask/design-tokens jest src/jsto verify changesScreenshots/Recordings
Before
Blue color values (old):
#0376c9#43aefc#0376c9#43aefcbefore720.mov
After
Blue color values (new):
#4459ff#8b99ff#4459ff#8b99ffafter720.mov
Pre-merge author checklist
Pre-merge reviewer checklist