Skip to content

Commit

Permalink
chore: retain src input amount after switching tokens (#29709)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29709?quickstart=1)

## **Related issues**

Fixes:   https://consensyssoftware.atlassian.net/browse/MMS-1798

## **Manual testing steps**

1. Load bridge page
2. Select amount, src token and dest token
3. Click token switch button to swap src and dest selections
4. Verify that src amount is preserved

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

Amount is cleared 

### **After**
Amount is preserved

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
micaelae authored Jan 17, 2025
1 parent 582ec93 commit 2751a0d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ui/pages/bridge/prepare/prepare-bridge-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,6 @@ const PrepareBridgePage = () => {
: undefined;
toChainClientId && dispatch(setActiveNetwork(toChainClientId));
dispatch(setFromToken(toToken));
dispatch(setFromTokenInputValue(null));
fromChain?.chainId && dispatch(setToChain(fromChain.chainId));
fromChain?.chainId && dispatch(setToChainId(fromChain.chainId));
dispatch(setToToken(fromToken));
Expand Down

0 comments on commit 2751a0d

Please sign in to comment.