fix: rm tests for setting src tokens

MetaMask · Jan 14, 2025 · a5192d5 · a5192d5
1 parent 89f88fa
commit a5192d5
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 89 deletions.
diff --git a/app/scripts/constants/sentry-state.ts b/app/scripts/constants/sentry-state.ts
@@ -110,9 +110,6 @@ export const SENTRY_BACKGROUND_STATE = {
       destTokens: {},
       destTopAssets: [],
       destTokensLoadingStatus: true,
-      srcTokens: {},
-      srcTopAssets: [],
-      srcTokensLoadingStatus: true,
       quoteRequest: {
         walletAddress: false,
         srcTokenAddress: true,

diff --git a/app/scripts/controllers/bridge/bridge-controller.test.ts b/app/scripts/controllers/bridge/bridge-controller.test.ts
@@ -11,8 +11,8 @@ import mockBridgeQuotesErc20Native from '../../../../test/data/bridge/mock-quote
 import mockBridgeQuotesNativeErc20 from '../../../../test/data/bridge/mock-quotes-native-erc20.json';
 import mockBridgeQuotesNativeErc20Eth from '../../../../test/data/bridge/mock-quotes-native-erc20-eth.json';
 import {
-  type QuoteResponse,
   RequestStatus,
+  type QuoteResponse,
 } from '../../../../shared/types/bridge';
 import { decimalToHex } from '../../../../shared/modules/conversion.utils';
 import BridgeController from './bridge-controller';
@@ -198,39 +198,6 @@ describe('BridgeController', function () {
     });
   });
 
-  it('selectSrcNetwork should set the bridge src tokens and top assets', async function () {
-    await bridgeController.selectSrcNetwork('0xa');
-    expect(bridgeController.state.bridgeState.srcTokens).toStrictEqual({
-      '0x0000000000000000000000000000000000000000': {
-        address: '0x0000000000000000000000000000000000000000',
-        decimals: 18,
-        iconUrl: './images/eth_logo.svg',
-        name: 'Ether',
-        symbol: 'ETH',
-      },
-      '0x1f9840a85d5af5bf1d1762f925bdaddc4201f984': {
-        address: '0x1f9840a85d5af5bf1d1762f925bdaddc4201f984',
-        symbol: 'ABC',
-        decimals: 16,
-        aggregators: ['lifl', 'socket'],
-      },
-    });
-    expect(
-      bridgeController.state.bridgeState.srcTokensLoadingStatus,
-    ).toStrictEqual(RequestStatus.FETCHED);
-    expect(bridgeController.state.bridgeState.srcTopAssets).toStrictEqual([
-      {
-        address: '0x1f9840a85d5af5bf1d1762f925bdaddc4201f984',
-        symbol: 'ABC',
-      },
-    ]);
-    expect(bridgeController.state.bridgeState.quoteRequest).toStrictEqual({
-      slippage: 0.5,
-      srcTokenAddress: '0x0000000000000000000000000000000000000000',
-      walletAddress: undefined,
-    });
-  });
-
   it('updateBridgeQuoteRequestParams should update the quoteRequest state', function () {
     bridgeController.updateBridgeQuoteRequestParams({ srcChainId: 1 });
     expect(bridgeController.state.bridgeState.quoteRequest).toStrictEqual({

diff --git a/test/e2e/default-fixture.js b/test/e2e/default-fixture.js
@@ -140,8 +140,6 @@ function defaultFixture(inputChainId = CHAIN_IDS.LOCALHOST) {
           },
           destTokens: {},
           destTopAssets: [],
-          srcTokens: {},
-          srcTopAssets: [],
         },
       },
       CurrencyController: {

diff --git a/test/e2e/fixture-builder.js b/test/e2e/fixture-builder.js
@@ -458,8 +458,6 @@ class FixtureBuilder {
         },
         destTokens: {},
         destTopAssets: [],
-        srcTokens: {},
-        srcTopAssets: [],
       },
     };
     return this;

diff --git a/test/e2e/tests/metrics/errors.spec.js b/test/e2e/tests/metrics/errors.spec.js
@@ -875,7 +875,6 @@ describe('Sentry errors', function () {
           walletAddress: false,
         },
         destTokensLoadingStatus: false,
-        srcTokensLoadingStatus: false,
         quotesLastFetched: true,
         quotesLoadingStatus: true,
         quotesRefreshCount: true,

diff --git a/test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json b/test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json
@@ -69,8 +69,6 @@
           "chains": { "0x1": "object", "0xa4b1": "object", "0xe708": "object" }
         }
       },
-      "srcTokens": {},
-      "srcTopAssets": {},
       "destTokens": {},
       "destTopAssets": {},
       "quoteRequest": {

diff --git a/test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json b/test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json
@@ -340,8 +340,6 @@
           "chains": { "0x1": "object", "0xa4b1": "object", "0xe708": "object" }
         }
       },
-      "srcTokens": {},
-      "srcTopAssets": {},
       "destTokens": {},
       "destTopAssets": {},
       "quoteRequest": {

diff --git a/test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-background-state.json b/test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-background-state.json
@@ -152,9 +152,7 @@
           }
         },
         "destTokens": {},
-        "destTopAssets": {},
-        "srcTokens": {},
-        "srcTopAssets": {}
+        "destTopAssets": {}
       }
     },
     "SubjectMetadataController": { "subjectMetadata": "object" },

diff --git a/test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-ui-state.json b/test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-ui-state.json
@@ -161,9 +161,7 @@
           }
         },
         "destTokens": {},
-        "destTopAssets": {},
-        "srcTokens": {},
-        "srcTopAssets": {}
+        "destTopAssets": {}
       }
     },
     "TransactionController": { "transactions": "object" },

diff --git a/ui/ducks/bridge/selectors.test.ts b/ui/ducks/bridge/selectors.test.ts
@@ -22,7 +22,6 @@ import {
   getFromChain,
   getFromChains,
   getFromToken,
-  getFromTokens,
   getIsBridgeTx,
   getToChain,
   getToChains,
@@ -499,42 +498,6 @@ describe('Bridge selectors', () => {
     });
   });
 
-  describe('getFromTokens', () => {
-    it('returns src tokens from controller state', () => {
-      const state = createBridgeMockStore({
-        bridgeSliceOverrides: { toChainId: '0x1' },
-        bridgeStateOverrides: {
-          srcTokens: { '0x00': { address: '0x00', symbol: 'TEST' } },
-          srcTopAssets: [{ address: '0x01', symbol: 'SYMB' }],
-        },
-      });
-      const result = getFromTokens(state as never);
-
-      expect(result).toStrictEqual({
-        fromTokens: {
-          '0x00': { address: '0x00', symbol: 'TEST' },
-        },
-        fromTopAssets: [{ address: '0x01', symbol: 'SYMB' }],
-        isLoading: false,
-      });
-    });
-
-    it('returns src top assets from controller state', () => {
-      const state = createBridgeMockStore({
-        bridgeSliceOverrides: { toChainId: '0x1' },
-        bridgeStateOverrides: {
-          srcTokens: { '0x00': { address: '0x00', symbol: 'TEST' } },
-          srcTopAssets: [{ address: '0x00', symbol: 'TEST' }],
-        },
-      });
-      const result = getFromTokens(state as never);
-
-      expect(result.fromTopAssets).toStrictEqual([
-        { address: '0x00', symbol: 'TEST' },
-      ]);
-    });
-  });
-
   describe('getBridgeQuotes', () => {
     it('returns quote list and fetch data, insufficientBal=false,quotesRefreshCount=5', () => {
       const state = createBridgeMockStore({