Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename the GanacheContractAddressRegistry class in preparation for ganache migration #28595

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 21, 2024

Description

The Contract Registry class, is going to be used as it is, in Anvil too.
In the efforts of making the migration PR smaller, this PR tackles the re-naming of this class GanacheContractAddressRegistry to a more generic name that can be used both by Ganache and Anvil ContractAddressRegistry.

Note: this PR doesn't introduce any functional change in the tests, so we can skip the quality gate for sparing ci credits.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3662

Manual testing steps

  1. Check all tests continues to work fine

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner November 21, 2024 07:12
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona self-assigned this Nov 21, 2024
@seaona seaona changed the title test: rename contract registry in preparation for ganache migration test: rename the GanacheContractAddressRegistry class in preparation for ganache migration Nov 21, 2024
@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Nov 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8bed0f5]
Page Load Metrics (2027 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44422171943362174
domContentLoaded18082149199011153
load18352217202712158
domInteractive26123602813
backgroundConnect1183392411
firstReactRender91160112168
getState56015157
initialActions01000
loadScripts12591622147010048
setupStore65818199
uiStartup20602461224612460
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@HowardBraham HowardBraham added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit fe5f85c Nov 22, 2024
112 checks passed
@HowardBraham HowardBraham deleted the rename-contract-registry-ganache branch November 22, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) release-12.9.0 Issue or pull request that will be included in release 12.9.0 skip-e2e-quality-gate team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants