fix: oldestPendingApproval and transactionsMetadata PropTypes in the …

[pedronfigueiredo]

…routes file

Description

There are two relatively new proptypes warnings that I included below. This is because transactionsMetadata is in fact an object, not an array of objects, and oldestPendingApproval can be undefined.

These PropTypes were introduced in #28301.

This PR updates both PropTypes definitions to avoid any more warnings.

Warning: Failed prop type: The prop `oldestPendingApproval` is marked as required in `Routes`, but its value is `undefined`.
    in Routes (created by Connect(Routes))
    in Connect(Routes) (created by Context.Consumer)
    in withRouter(Connect(Routes)) (at pages/index.js:57)
    in MetamaskNotificationsProvider (at pages/index.js:56)
    in MetamaskIdentityProvider (at pages/index.js:55)
    in AssetPollingProvider (at pages/index.js:54)
    in LegacyI18nProvider (at pages/index.js:53)
    in I18nProvider (at pages/index.js:52)
    in LegacyMetaMetricsProvider (at pages/index.js:51)
    in MetaMetricsProvider (at pages/index.js:50)
    in RenderedRoute (created by Routes)
    in Routes (created by CompatRouter)
    in Router (created by CompatRouter)
    in CompatRouter (at pages/index.js:49)
    in Router (created by HashRouter)
    in HashRouter (at pages/index.js:48)
    in Provider (at pages/index.js:47)
    in Index (at ui/index.js:213)
Warning: Failed prop type: Invalid prop `transactionsMetadata` of type `object` supplied to `Routes`, expected an array.
    in Routes (created by Connect(Routes))
    in Connect(Routes) (created by Context.Consumer)
    in withRouter(Connect(Routes)) (at pages/index.js:57)
    in MetamaskNotificationsProvider (at pages/index.js:56)
    in MetamaskIdentityProvider (at pages/index.js:55)
    in AssetPollingProvider (at pages/index.js:54)
    in LegacyI18nProvider (at pages/index.js:53)
    in I18nProvider (at pages/index.js:52)
    in LegacyMetaMetricsProvider (at pages/index.js:51)
    in MetaMetricsProvider (at pages/index.js:50)
    in RenderedRoute (created by Routes)
    in Routes (created by CompatRouter)
    in Router (created by CompatRouter)
    in CompatRouter (at pages/index.js:49)
    in Router (created by HashRouter)
    in HashRouter (at pages/index.js:48)
    in Provider (at pages/index.js:47)
    in Index (at ui/index.js:213)

Related issues

Fixes: N/A

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [b8a38ff]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1749 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	175	2067	1526	533	256
		domContentLoaded	1486	2052	1732	191	92
		load	1497	2074	1749	194	93
		domInteractive	23	162	43	32	15
		backgroundConnect	9	52	21	12	6
		firstReactRender	15	78	49	23	11
		getState	5	71	21	20	10
		initialActions	0	0	0	0	0
		loadScripts	1075	1553	1276	156	75
		setupStore	6	61	13	15	7
		uiStartup	1674	2350	1996	199	96

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 43 Bytes (0.00%)
• ui: 5.85 KiB (0.07%)
• common: 81 Bytes (0.00%)