Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add soneium logo #29713

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: add soneium logo #29713

merged 2 commits into from
Jan 16, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 14, 2025

Description

Adding Soneium Mainnet and Soneium Testnet

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Adding Soneium network to the metamask
image 2. Click the Metamask icon to add network 3. Open Metamask extension to check the network and token icons

Open Metamask extension to check the network and token icons

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jan 14, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb marked this pull request as ready for review January 14, 2025 20:10
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [c48e76b]
Page Load Metrics (1786 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34820601664447215
domContentLoaded15502046176513464
load15562069178613666
domInteractive27159643115
backgroundConnect65318136
firstReactRender16152493517
getState46917199
initialActions01000
loadScripts11631530133110550
setupStore55214157
uiStartup17332583204620297
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 344 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Jan 15, 2025
@sahar-fehri
Copy link
Contributor

related to #29713

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f3a195b]
Page Load Metrics (2231 ± 522 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33638931490753361
domContentLoaded1506477722021083520
load1520481122311088522
domInteractive22246655828
backgroundConnect481282110
firstReactRender15195564823
getState45520178
initialActions01000
loadScripts110734911643821394
setupStore681232211
uiStartup1751599125991283616
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 344 Bytes (0.00%)

@bergeron bergeron added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 933bd1b Jan 16, 2025
80 checks passed
@bergeron bergeron deleted the fix/add-soneium-logo branch January 16, 2025 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-12.11.1 Issue or pull request that will be included in release 12.11.1 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.11.1 Issue or pull request that will be included in release 12.11.1 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants